Acked-by: Eitan Eliahu <[email protected]> Thanks, Eitan
-----Original Message----- From: dev [mailto:[email protected]] On Behalf Of Nithin Raju Sent: Thursday, October 30, 2014 1:18 PM To: [email protected] Subject: [ovs-dev] [PATCH] datapath-windows: don't leak NBLs with multiple NBs Currently, if we receive an NBL with multiple NBs from NDIS, we just ASSERT() and not do anything. The right thing to do obviously is to process the NBL. This is a work in progress. In the meantime, we should complete the NBL and not just leak it. Signed-off-by: Nithin Raju <[email protected]> --- datapath-windows/ovsext/PacketIO.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/datapath-windows/ovsext/PacketIO.c b/datapath-windows/ovsext/PacketIO.c index 5223125..1af391b 100644 --- a/datapath-windows/ovsext/PacketIO.c +++ b/datapath-windows/ovsext/PacketIO.c @@ -218,7 +218,12 @@ OvsStartNBLIngress(POVS_SWITCH_CONTEXT switchContext, curNb = NET_BUFFER_LIST_FIRST_NB(curNbl); if (curNb->Next != NULL) { /* XXX: This case is not handled yet. */ - ASSERT(FALSE); + RtlInitUnicodeString(&filterReason, + L"Dropping NBLs with multiple NBs"); + OvsStartNBLIngressError(switchContext, curNbl, + sendCompleteFlags, &filterReason, + NDIS_STATUS_RESOURCES); + continue; } else { POVS_BUFFER_CONTEXT ctx; OvsFlow *flow; -- 1.7.4.1 _______________________________________________ dev mailing list [email protected] https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=AAIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=eBsQWoZhtO0FkZENx8e32oBwz_8dyBD5ZdWrNX0xHFA&s=DJ4a2mzcNKfRjruNQR14Xtkm3kg4L5LnWyqNwnUFFg0&e= _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
