On Fri, Oct 31, 2014 at 06:05:24PM +0530, Rishi Bamba wrote: > From: rishibamba <rishiba...@users.noreply.github.com> > > This patch enables a user to set importance for a new rule via add-flow > OF1.1+ in the OVS and display the same via dump-flows command OF1.1+ . > The changes are made in accordance with OpenFlow 1.4 specs to implement > Eviction on the basis of "importance". > > Signed-off-by: Rishi Bamba <rishi.ba...@tcs.com>
Thanks for the patch! It applies properly to my tree. I am glad that you were able to work out how to send patches by email. In ofputil_decode_flow_mod(), I would only take the importance from the flow_mod if it is for OpenFlow 1.4 or later. Similarly for ofputil_encode_flow_mod(), ofputil_decode_flow_stats_reply(), and ofputil_append_flow_stats_reply(). I see that this patch adds an 'importance' field to struct ofputil_flow_removed, but I don't see any code that reads or writes it or encodes or decodes it. Please correct that. I look forward to the next version of the patch (it looks like there should only be one, not five). Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
