On Fri, Oct 31, 2014 at 04:50:30PM -0700, Jesse Gross wrote:
> On Fri, Oct 31, 2014 at 4:29 PM, Ben Pfaff <[email protected]> wrote:
> > packets.h uses a LITTLE_ENDIAN macro for Geneve:
> >
> > struct geneve_opt {
> > ovs_be16 opt_class;
> > uint8_t type;
> > #ifdef LITTLE_ENDIAN
> > uint8_t length:5;
> > uint8_t r3:1;
> > uint8_t r2:1;
> > uint8_t r1:1;
> > #else
> > uint8_t r1:1;
> > uint8_t r2:1;
> > uint8_t r3:1;
> > uint8_t length:5;
> > #endif
> > uint8_t opt_data[];
> > };
> >
> > I don't think we have such a macro. The rest of the userspace code
> > tests for WORDS_BIGENDIAN.
>
> It is defined on my machine but I agree that it is not portable. I'll
> send out a patch to fix it.
It's defined on my machine too, but not usefully:
blp@sigabrt:~/nicira/ovs(0)$ cat > test.c
#include <endian.h>
LITTLE_ENDIAN
BIG_ENDIAN
PDP_ENDIAN
blp@sigabrt:~/nicira/ovs(0)$ gcc -E test.c | tail -3
1234
4321
3412
blp@sigabrt:~/nicira/ovs(0)$
Thanks for the patch.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
