On Wed, Nov 05, 2014 at 02:48:43PM -0800, Jarno Rajahalme wrote:
> Keep knowledge about ofproto-dpif internal rules within ofproto-dpif.
> This removes duplication of code (accross multiple files), and allows
> making the ofproto-dpif-xlate interface a bit smaller.
>
> 'may_packet_in' was previously not honored for the
> 'LOOKUP_VERDICT_DEFAULT' case. Now it is, but this change did not
> break any unit tests.
>
> Also, previously in the 'LOOKUP_VERDICT_CONTROLLER' case packet-in
> messages would have been generated when the in_port could not be found
> ('config' was set to zero in this case, causing 'OFPUTIL_PC_NO_PACKET_IN'
> flag to be zero as well). This patch changes this behavior and never
> issues packet-in messages when the in_port cannot be found. This did
> not break any unit tests either.
>
> Signed-off-by: Jarno Rajahalme <[email protected]>
This is a nice cleanup. This area is a thicket of complicated rules. I
am encouraged that the unit tests pass. I am not really certain that
that is enough, but it's good enough for me to be willing to wait for
bug reports on anything we missed.
Acked-by: Ben Pfaff <[email protected]>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
