Hi Ben,
> > This patch enables a user to set importance for a new rule via
> > add-flow
> > OF1.4+ in the OVS and display the same via dump-flows command
> > OF1.4+ .
> > The changes are made in accordance with OpenFlow 1.4 specs to
> > implement
> > Eviction on the basis of "importance".This patch also enhances the
> > diff-flows & replace-flows CLI for addition of importance parameter
> > in
> > a rule.
> >
> > Also changes are made to DESIGN.md and added test cases for
> > add-flow &
> > replace-flows.
> >
> > Signed-off-by: Rishi Bamba <rishi.ba...@tcs.com>
>
> Thanks for the updated patch. I have some comments.
>
> The patch author should be the same as the signoff. Please don't use
> alternate spellings ("rishibamba") or invalid email addresses
> ("rishiba...@users.noreply.github.com"), as above.
The same has been fixed.Apologies for any inconvenience caused.
> The importance is not a flow timeout, so please do not use
> OFP_FLOW_PERMANENT. Just write 0.
As mentioned earlier , we were thinking of it as if importance is set then its
evictable
else will be considered as a permanent flow.
Though the changes are made in accordance to the review comments.
> In ofputil_decode_flow_mod() and ofputil_encode_flow_mod(), it is not
> necessary to check both 'protocol' and OpenFlow version. The version
> is
> enough. Please check for version >= OFP14_VERSION, instead of for
> OF1.4
> and OF1.5 specifically, because it is likely that later OpenFlow
> versions will use the same format.
Thanks, the same has been corrected for both these functions and for
ofputil_append_flow_stats_reply(),
ofputil_decode_flow_stats_reply too.
> Please document the new feature in utilities/ovs-ofctl.8.in and
> mention
> it in NEWS.
NEWS and utilities/ovs-ofctl.8.in have been updated accordingly.
Will be submitting the next revision of the patch incorporating all the above
changes.
Thanks & Regards
Rishi Bamba
=====-----=====-----=====
Notice: The information contained in this e-mail
message and/or attachments to it may contain
confidential or privileged information. If you are
not the intended recipient, any dissemination, use,
review, distribution, printing or copying of the
information contained in this e-mail message
and/or attachments to it are strictly prohibited. If
you have received this communication in error,
please notify us by reply e-mail or telephone and
immediately and permanently delete the message
and any attachments. Thank you
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
