hi Ankur, Thanks for the review. I'll send out a v2 once all the patches get reviewed.
On Nov 17, 2014, at 5:38 PM, Ankur Sharma <ankursha...@vmware.com> wrote: > Minor comments inline. > > Acked-by: Ankur Sharma <ankursha...@vmware.com> > +static POVS_VPORT_ENTRY OvsFindVportByHvNameW( > + POVS_SWITCH_CONTEXT switchContext, PWSTR wsName, SIZE_T wstrSize); > > [ANKUR]: formatting should be fixed. Sure, I tried to follow the approach of leaving 4 spaces from the start of return type. I'll see if I can do better. > +POVS_VPORT_ENTRY OvsFindVportByPortIdAndNicIndex( > + struct _OVS_SWITCH_CONTEXT *switchContext, NDIS_SWITCH_PORT_ID portId, > + NDIS_SWITCH_NIC_INDEX index); > > [ANKUR]: formatting should be fixed. Sure, I tried to follow the approach of leaving 4 spaces from the start of return type. I'll see if I can do better. thanks, -- Ntihin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
