hi Sorin,
In order to call OvsSendNBLIngress() on an NBL, we should have allocated an OVS
external context for it, using OvsInitExternalNBLContext(). Otherwise, on the
completion path, we'll not know how to handle this NBL.
> + PNET_BUFFER_LIST extForwardedNbls = NULL;
> + PNET_BUFFER_LIST nativeForwardedNbls = NULL;
> + PNET_BUFFER_LIST *nextExtForwardNbl = &extForwardedNbls;
> + PNET_BUFFER_LIST *nextNativeForwardedNbl = &nativeForwardedNbls;
Just a suggestion: extForwardedNbls => ovsForwarddedNbls.
nextExtForwardNbl => nextOvsForwardNbl
> +#if (NDIS_SUPPORT_NDIS640)
> + /*
> + * Split NBL list into NBLs to be forwarded by us, and those that require
> + * native forwarding. */
Minor:
/*
* comment.
*/
and not:
/*
* comment */
> + if (fwdDetail->NativeForwardingRequired) {
> + *nextNativeForwardedNbl = curNbl;
> + nextNativeForwardedNbl = &(curNbl->Next);
> + }
> + else
> + {
> + *nextExtForwardNbl = curNbl;
> + nextExtForwardNbl = &(curNbl->Next);
> + }
Minor:
if (cond) {
stmt-if;
} else {
stmt-else;
}
thanks,
-- Nithin
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
