On Fri, Nov 21, 2014 at 03:13:40PM +0530, Saloni Jain wrote:
> >There is no need for this code in handle_table_desc_request() because
> >higher-level code has already checked these properties for
> >correctness:
> > ofpbuf_use_const(&msg, request, ntohs(request->length));
> > ofpraw_pull_assert(&msg);
> > if (ofpbuf_size(&msg) || ofpmp_more(request)) {
> > return OFPERR_OFPTFFC_EPERM;
> > }
>
> We have rechecked the code, the higher-level code is not performing
> these checks. Also same checking has been done for
> handle_table_feature_request()
ofptype_decode() and related functions check that the length of a
message agrees with the specification given in enum ofpraw in
ofp-msgs.h, so there is no need to do that again here.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
