On Mon, Dec 29, 2014 at 01:05:49PM -0800, Pravin B Shelar wrote:
> Kernel datapath expect specific order when it comes to mpls and vlan
> action combination. Datapath can push mpls first and then vlan and
> reverse for pop action. Following patch generate actions in
> correct order and enforces this requirement for Open Flow
> actions so that user can see rejected actions.
>
> Signed-off-by: Pravin B Shelar <pshe...@nicira.com>
I don't think that it's correct to forbid a "push mpls" action in the
presence of a VLAN tag. OpenFlow 1.3.4 and 1.5 both define this to
mean that the MPLS tag should be inserted *after* the VLAN header.
See the following commit:
commit 269dc90a0a090f2b40e55b4572ac5edeb1684b7d
Author: Ben Pfaff <b...@nicira.com>
Date: Tue Feb 4 12:39:37 2014 -0800
Always insert MPLS labels after VLAN tags.
OpenFlow 1.1 and 1.2 always inserted MPLS labels after VLAN tags.
OpenFlow 1.3 and 1.4 insert MPLS labels before VLAN tags.
OpenFlow 1.3.4 and 1.5, both in preparation, recognize that the change
in
1.3 was an error and revert it. This commit implements that reversion
in Open vSwitch.
EXT-457.
Signed-off-by: Ben Pfaff <b...@nicira.com>
Acked-by: Simon Horman <ho...@verge.net.au>
Similarly for "pop mpls"
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
