On Fri, Jan 16, 2015 at 05:01:24PM +0000, Flynn, Dennis R (Dennis) wrote: > Hi Ben, > > After looking more carefully at the logic that parses the LLDP_TLV_MGMT_ADDR > TLV I agree there is a bug here. > This is actually code from the open source LLDPD project. > > I have opened an issue within that project describing this problem. > In the mean time I have modified this code within OvS to fix this bug and am > testing that now. > > Also I am familiarizing myself with the OvS unit test environment (i.e. > Autotest) with the intent of adding new tests for Auto-Attach (AA). > At this point I can provide my fix to the LLDP_TLV_MGMT_ADDR problem so that > we can move forward with the AA submission.
OK, great. I imagine that the change is pretty small. > From your perspective do you require that the new AA unit tests be in place > before accepting the AA code? No. I'd prefer to hear a commitment to improve the unit tests over time. > Do you have any further insight regarding the "Code Complete" date for > OvS 2.4? I don't know of a date, but this isn't something that should keep the AA code out. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
