On Mon, Jan 26, 2015 at 11:25 AM, Ben Pfaff <[email protected]> wrote: > On Mon, Jan 26, 2015 at 09:00:18AM -0800, Gurucharan Shetty wrote: >> When Open vSwitch is run in hundreds of hypervisors, it is >> useful to collect log messages through log collectors. To >> collect log messages like this, it is useful to log them >> in a particular RFC5424 facility in the local system. The >> log collectors can then be used to collect logs anytime >> desired. >> >> This commit provides a sysadmin the ability to specify the >> facility through which the log messages are logged. >> >> Signed-off-by: Gurucharan Shetty <[email protected]> > > Does this compile OK on Windows (I wonder whether it has these LOG_* > constants)? It will most likely fail (oops!, I should have known better). I will add the additional constants to include/windows/syslog.h
> > vlog is mostly configurable at runtime using appctl commands. Should > the log facility also be configurable? I thought about it and started coding it. I had to take a read write lock to protect the global variable that could now be changed anytime. Since, we need to look at the variable for every log message, I was not sure whether it makes sense to have the overhead unless someone really wants it. If you think it is worthwhile, I will re-spin this with that change. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
