On Thu, Jan 08, 2015 at 04:29:13PM -0500, Thomas F Herbert wrote:
> This patch adds support for 802.1AD by adding parsing of 802.1AD double
> stacked vlans.
> 
> Signed-off-by: Thomas F Herbert <thomasfherb...@entpnt.com>

It looks like odp_flow_key_from_flow__() only ever pushes one VLAN
header into the ODP flow key (or maybe I'm misinterpreting it?).

It looks like parse_8021ad_onward() duplicates a lot of code from
parse_8021q_onward().  I think it would be better to try to keep as much
common code as possible.

Please be careful about CodingStyle.  In particular I see a number of
code blocks that lack {}.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to