On Wed, Feb 11, 2015 at 02:16:51PM -0800, Gurucharan Shetty wrote:
> testsuite uses mkfifo in its job dispatcher that manages
> parallel unit tests. MinGW does not have a mkfifo. This
> results in unit tests running serially on Windows. Right
> now it takes up to approximately 40 minutes to run all the
> unit tests on Windows.
>
> This commit provides a job dispatcher for MinGW that uses
> temporary files instead of mkfifo to manage parallel jobs.
> With this commit, on a Windows machine with 4 cores and with
> 8 parallel unit test sessions, it takes approximately 8
> minutes to finish a unit test run.
>
> Signed-off-by: Gurucharan Shetty <[email protected]>
Thanks for doing this. I really like changes that make it easier or
faster to run tests, because then developers are more likely to run
them.
I don't think that "patch" is currently required to build OVS. I think
that it's reasonable to require it--it is such a common utility--but I
think that we should mention it in INSTALL.md.
In the Makefile fragment, I would prefer to apply the patch before
renaming the file. That way, the new version of the testsuite appears
atomically.
> ++elif [ "$IS_WIN32" = "yes" ]; then
The UNIX version of the parallel dispatcher has a few more tests:
if test $at_jobs -ne 1 &&
rm -f "$at_job_fifo" &&
test -n "$at_job_group" &&
( mkfifo "$at_job_fifo" && trap 'exit 1' PIPE STOP TSTP ) 2>/dev/null
Maybe it is worth checking at least that $at_jobs > 1?
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
