On Fri, Feb 13, 2015 at 06:14:28PM -0500, Simon Horman wrote: > On Fri, Feb 13, 2015 at 02:55:58PM -0800, Ben Pfaff wrote: > > On Fri, Jan 30, 2015 at 11:41:51AM +0900, Simon Horman wrote: > > > This is in preparation for supporting group mod and desc reply > > > messages with an NMX selection method group experimenter property. > > > > > > NMX selection method > > > Signed-off-by: Simon Horman <simon.hor...@netronome.com> > > > > > > --- > > > v2 Use list of struct field_array of TLVs rather than OF1.1 match > > > for fields field of NMX selection method property > > > > It might be simpler to use an actual array for struct field_array. I > > guess that we can be sure there will be no more than MFF_N_IDS > > elements? > > As duplicates are rejected I believe that we can make that assumption. > > I think that should simplify the code somewhat at the > expense of some memory cost if the property is present. > I'm assuming that you are happy about the latter and > I'll see about making it so.
I'm not sure yet as I haven't read the rest of the series yet. If you're unsure then you might want to wait for the rest of the reviews. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
