On Fri, Feb 20, 2015 at 9:15 AM, Jesse Gross <je...@nicira.com> wrote: > On Fri, Feb 20, 2015 at 2:38 AM, Thomas Graf <tg...@noironetworks.com> wrote: >> On 02/19/15 at 04:42pm, Pravin Shelar wrote: >>> Did you considered getting rid of USE_KERNEL_TUNNEL_API and various >>> kernel version check. And just have one version check of 3.18 kernel >>> to implement all tunnel backports? >>> At this point we have most of tunnel code backported (few missing >>> function like iptunnel_handle_offloads()). So we can define compat >>> code for kernel older than 3.18, then only check we need is if >>> ovs-compat code needs to handle GSO packets or not. We can merge 3.12 >>> and 3.18 kernel backport cases and handle the gso check in >>> iptunnel_handle_offloads(). That code will be easier to read and >>> debug. >> >> USE_KERNEL_TUNNEL_API still has some RHEL6 backport build logic built >> in. See the comment in ip_tunnels.h. I have no objection to removing >> it but we should do a build test on RHEL6 and RHEL7 first. Flavio >> might be able to help out. > > I'm finishing up the implementation of this and it definitely makes > things cleaner. It also reduces the points of possible backport > conflict (basically only GSO is used with the compat code). I'm > looking at RHEL now although it would still be great if somebody can > do a build test.
Actually, I was able to do a build test on RHEL6 and 7 myself. I just sent out v3 of the series which is quite a bit simpler than the previous one. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
