On Fri, Feb 20, 2015 at 1:30 PM, Ben Pfaff <b...@nicira.com> wrote: > On Fri, Feb 20, 2015 at 1:27 PM, Jesse Gross <je...@nicira.com> wrote: >> On Fri, Feb 20, 2015 at 1:11 PM, Thomas Graf <tg...@noironetworks.com> wrote: >>> This is an extremely nice cleanup overall. >>> >>> On 02/20/15 at 10:50am, Jesse Gross wrote: >>>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,9,0) >>>> +#define SKB_GSO_GRE 0 >>>> +#endif >>>> + >>>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,16,0) >>>> +#define SKB_GSO_GRE_CSUM 0 >>>> +#endif >>> >>> You might as well just check with #ifndef SKB_GSO_GRE to be more >>> liberal to future backports, e.g. I assume that RHEL7 will >>> eventually have SKB_GSO_GRE_CSUM and will declare itself as 3.10 >> >> I would have liked to do that but these are defined through an enum in >> the upstream source rather than a #define there isn't an easy way to >> check. > > You could of course use the configure-time "grep" feature, if it's important.
Sure, it just didn't seem worth it to do it speculatively as I was trying to reduce the number of different checks in this patch. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
