> On 25 Feb 2015, at 19:59, Ben Pfaff <[email protected]> wrote:
>
> On Wed, Feb 25, 2015 at 04:47:09PM +0000, Daniele Di Proietto wrote:
>> With this commit the '--dpdk' option doesn't need to be at the beginning
>> of the command line. Furthermode, the code that calls 'rte_eal_init()'
>> can be slightly simplified by using the 'optind' variable. The change is
>> totally backward compatible
>>
>> Documentation and manpages are updated accordingly.
>>
>> Signed-off-by: Daniele Di Proietto <[email protected]>
>
>> +bool dpdk_is_initialized()
>
> Careful about the C style here, that should be:
>
> bool
> dpdk_is_initialized(void)
>
You’re right, noted
>> +{
>> + return dpdk_initialized;
>> }
>>
>> const struct netdev_class dpdk_class =
>
> I read the rest and it looks good to me, but Pravin should probably
> ack it too.
Sure, thanks for the review!
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
