Thx for the review, applied to master As Joe suggested, I'll add another test for testing the hash_bytes128 using single 128-bit word. And find the magic number n such that there is no collision in all n-bit consecutive runs.
Thanks, Alex Wang, On Fri, Feb 27, 2015 at 8:04 AM, Ben Pfaff <[email protected]> wrote: > On Thu, Feb 26, 2015 at 10:40:54AM -0800, Alex Wang wrote: > > The original test fails on big-endian system due to the hash function > > performing not as well when input is uint32_t. In reality, users should > > only use hash_bytes128() to hash words larger than 128 bits (e.g. struct > > flow). Besides, we do check the 1-bit set case for 16 128-bit words in > > following test case. Therefore, the cleanest way to fix the failure > > in big-endian system seems to be just removing the check_word_hash() > > test for hash_bytes128_cb. > > > > Signed-off-by: Alex Wang <[email protected]> > > This seems like an OK compromise. > > Acked-by: Ben Pfaff <[email protected]> > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
