I think this is sufficient, but I am not an expert at these things. So, just to be sure, can you reply back with the following one liner. Signed-off-by: Gianluca Merlo <[email protected]>
Thanks, Guru On Mon, Mar 2, 2015 at 1:55 PM, Gianluca Merlo <[email protected]> wrote: > Hello, > > I appreciate your concern and kindness. I confirm the sign-off for my patch. > I apologize in advance if this simple indication is not sufficient for your > needs, and I hope you will provide additional details on how to properly > confirm the sign-off should this message not suffice. > > Best regards. > > Gianluca Merlo > > 2015-03-02 16:25 GMT+01:00 Gurucharan Shetty <[email protected]>: >> >> On Sat, Feb 28, 2015 at 9:05 PM, Ben Pfaff <[email protected]> wrote: >> > From: Gianluca Merlo <[email protected]> >> Thank you Gianluca for the fix. Can I have you reply to this email >> with a "Signed-off-by". The meaning of a Signed-off-by by is present >> in the CONTRIBUTING.md file of the ovs repo. I am pasting it here for >> your convenience. >> >> Developer's Certificate of Origin >> --------------------------------- >> >> To help track the author of a patch as well as the submission chain, >> and be clear that the developer has authority to submit a patch for >> inclusion in openvswitch please sign off your work. The sign off >> certifies the following: >> >> Developer's Certificate of Origin 1.1 >> >> By making a contribution to this project, I certify that: >> >> (a) The contribution was created in whole or in part by me and I >> have the right to submit it under the open source license >> indicated in the file; or >> >> (b) The contribution is based upon previous work that, to the best >> of my knowledge, is covered under an appropriate open source >> license and I have the right under that license to submit that >> work with modifications, whether created in whole or in part >> by me, under the same open source license (unless I am >> permitted to submit under a different license), as indicated >> in the file; or >> >> (c) The contribution was provided directly to me by some other >> person who certified (a), (b) or (c) and I have not modified >> it. >> >> (d) I understand and agree that this project and the contribution >> are public and that a record of the contribution (including all >> personal information I submit with it, including my sign-off) is >> maintained indefinitely and may be redistributed consistent with >> this project or the open source license(s) involved. >> >> >> > >> > Reuse code for determining attached port to prevent ovs-docker to >> > proceed if a >> > port for the given container and interface is already attached. >> > --- >> > I'm posting this patch that was already submitted as a Github pull >> > request at: https://github.com/openvswitch/ovs/pull/36 >> > >> > utilities/ovs-docker | 8 ++++++++ >> > 1 file changed, 8 insertions(+) >> > >> > diff --git a/utilities/ovs-docker b/utilities/ovs-docker >> > index 099ba31..d157fc1 100755 >> > --- a/utilities/ovs-docker >> > +++ b/utilities/ovs-docker >> > @@ -73,6 +73,14 @@ add_port () { >> > exit 1 >> > fi >> > >> > + # Check if a port is already attached for the given container and >> > interface >> > + PORT=`get_port_for_container_interface "$CONTAINER" "$INTERFACE" >> > 2>/dev/null` >> > + if [ -n "$PORT" ]; then >> > + echo >&2 "$UTIL: Port already attached" \ >> > + "for CONTAINER=$CONTAINER and INTERFACE=$INTERFACE" >> > + exit 1 >> > + fi >> > + >> > if ovs_vsctl br-exists "$BRIDGE" || \ >> > ovs_vsctl add-br "$BRIDGE"; then :; else >> > echo >&2 "$UTIL: Failed to create bridge $BRIDGE" >> > -- >> > 2.1.3 >> > >> > _______________________________________________ >> > dev mailing list >> > [email protected] >> > http://openvswitch.org/mailman/listinfo/dev > > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
