The appveyor build on Windows failed (see
https://ci.appveyor.com/project/blp/ovs/build/1.0.41):
c:\openvswitch\lib\ofp-actions.h(461) : error C2229: struct 'ofpact_nest'
has an illegal zero-sized array
c:\openvswitch\lib\ofp-actions.h(756) : error C2719: 'a': formal parameter
with __declspec(align('8')) won't be aligned
c:\openvswitch\lib\ofp-actions.h(756) : error C2719: 'b': formal parameter
with __declspec(align('8')) won't be aligned
That's about this code:
458 struct ofpact_nest {
459 struct ofpact ofpact;
460 uint8_t pad[PAD_SIZE(sizeof(struct ofpact), OFPACT_ALIGNTO)];
461 struct ofpact actions[];
462 };
I agree with it that pad[] is zero bytes long now, since "struct
ofpact" is now 8 bytes long. That's a bit wasteful don't you think
since only 4 bytes of it is actually used? I guess the solution would
be to remove pad[] or to shrink struct ofpact back to 4 bytes.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
