On 03/16/2015 05:16 PM, Russell Bryant wrote: > On 03/16/2015 05:08 PM, Ben Pfaff wrote: >> Would you mind fixing that up? > > No problem at all. Thanks for the feedback! I'll also start testing > builds with both gcc and clang, instead of just gcc. I wonder how I > missed the error ... I'll get it fixed up in any case.
To get a clean build of master with clang, I needed to use the following: CFLAGS="-Werror -Qunused-arguments -Wno-unused-value -Wno-tautological-compare" Does that match your dev environment? I wonder if it's worth at least documenting these. It could be a new section in CodingStyle.md about patch submission expectations that covers things like: builds with gcc and clang without error when using -Werror + expected additional flags, test suite still passes, ... -- Russell Bryant _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
