On Tue, Mar 17, 2015 at 03:17:07PM -0700, Ben Pfaff wrote:
> On Mon, Mar 09, 2015 at 10:11:00AM +0900, Simon Horman wrote:
> > Include NTR selection method experimenter group property in
> > in group mod request and group desc reply.
> >
> > NTR selection method
> > Signed-off-by: Simon Horman <[email protected]>
> >
> > ---
> >
> > v3
> > * Use fixed array for fields_array rather than constructing a list
> > * Use NTR instead of NMX as Netronome extension prefix
> >
> > v2
> > * Use list of struct field_array of TLVs rather than OF1.1 match
> > for fields field of NTR selection method property
>
> ofp_print_group() has provisions for handling oxm_format_field_array()
> failing, but I don't see how that can happen.
Agreed. I have changed the return type of oxm_format_field_array()
to void and updated ofp_print_group() accordingly.
>
> This seems like an unrelated (unneeded?) change in ofp_print_group():
>
> LIST_FOR_EACH (bucket, list_node, p_buckets) {
> ds_put_cstr(s, "bucket=");
>
> - ofp_print_bucket_id(s, "bucket_id:", bucket->bucket_id, ofp_version);
> + ofp_print_bucket_id(s, "bucket_id:", bucket->bucket_id,
> + ofp_version);
> if (bucket->weight != 1) {
> ds_put_format(s, "weight:%"PRIu16",", bucket->weight);
> }
> if (bucket->watch_port != OFPP_NONE) {
> ds_put_format(s, "watch_port:%"PRIu32",", bucket->watch_port);
> }
> if (bucket->watch_group != OFPG11_ANY) {
> - ds_put_format(s, "watch_group:%"PRIu32",", bucket->watch_group);
> + ds_put_format(s, "watch_group:%"PRIu32",",
> + bucket->watch_group);
> }
>
> ds_put_cstr(s, "actions=");
> ofpacts_format(bucket->ofpacts, bucket->ofpacts_len, s);
> ds_put_char(s, ',');
Thanks, sorry for that noise.
> Otherwise I'm happy with this patch. Thank you!
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
