On 04/05/15 at 03:03pm, Ben Pfaff wrote: > Thanks Justin and Ethan. Applied to master, with your acks. > > On Sun, Apr 05, 2015 at 01:46:55PM -0700, Ethan Jackson wrote: > > I think this is fine. Though I agree with Justin the script > > documentation should be update. I can take care of that tomorrow. > > > > Acked-by: Ethan Jackson <[email protected]> > > > > > > On Sun, Apr 5, 2015 at 1:40 PM, Ben Pfaff <[email protected]> wrote: > > > This is hardly urgent so I'll leave this one for Ethan to review. > > > > > > On Sun, Apr 05, 2015 at 12:35:38PM -0700, Justin Pettit wrote: > > >> For the actual change: > > >> > > >> Acked-by: Justin Pettit <[email protected]> > > >> > > >> In this script, the documentation calls out insmod'ing openvswitch.ko. > > >> My guess is that if someone is explicitly insmod'ing the main OVS kernel > > >> module, the environment won't be setup to pull in the appropriate vport > > >> kernel modules. I wonder if the documentation should be updated. > > >> Ethan, I think this is your baby, so what do you think?
Given this statement, I will respin the vport rmmod patch to also insmod the previously removed vports again as kmods without deps generated seem to be a valid use case. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
