hi, thank you for review.
you are right. i didn't notice the code in ofconn_send. thank you. i tend to think it's nicer to have ofputil_encode_xxx generate the complete packet, though. background: my code [1] uses libofproto to generate on-wire packet and write it out to a file. thus ofconn_send is not involved. i'll add ofpmsg_update_length calls in my code for now. YAMAMOTO Takashi [1] https://github.com/osrg/ryu/tree/master/ryu/tests/packet_data_generator2 > Yamamoto, > > ofconn_send(), which will eventually be called for these, already does > ofpmsg_update_length() before passing the message to rconn_send(). Given > this, it seems unnecessary to make this change. > > Jarno > >> On Apr 6, 2015, at 11:43 PM, YAMAMOTO Takashi <[email protected]> wrote: >> >> Signed-off-by: YAMAMOTO Takashi <[email protected]> >> --- >> lib/ofp-util.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/lib/ofp-util.c b/lib/ofp-util.c >> index a0da289..7035c8c 100644 >> --- a/lib/ofp-util.c >> +++ b/lib/ofp-util.c >> @@ -8760,6 +8760,7 @@ ofputil_encode_bundle_ctrl_reply(const struct >> ofp_header *oh, >> m->type = htons(msg->type); >> m->flags = htons(msg->flags); >> >> + ofpmsg_update_length(buf); >> return buf; >> } >> >> @@ -8906,5 +8907,6 @@ ofputil_encode_bundle_add(enum ofp_version ofp_version, >> m->flags = htons(msg->flags); >> ofpbuf_put(request, msg->msg, ntohs(msg->msg->length)); >> >> + ofpmsg_update_length(request); >> return request; >> } >> -- >> 2.1.0 >> >> _______________________________________________ >> dev mailing list >> [email protected] >> http://openvswitch.org/mailman/listinfo/dev > > _______________________________________________ > dev mailing list > [email protected] > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
