On Mon, Apr 13, 2015 at 12:40 PM, Jesse Gross <[email protected]> wrote: > On Mon, Apr 13, 2015 at 11:15 AM, Pravin Shelar <[email protected]> wrote: >> On Thu, Apr 9, 2015 at 11:15 AM, Jesse Gross <[email protected]> wrote: >>> diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h >>> index 337d13a..dce4c67 100644 >>> --- a/datapath/linux/compat/gso.h >>> +++ b/datapath/linux/compat/gso.h >>> @@ -52,6 +52,15 @@ static inline int skb_inner_network_offset(const struct >>> sk_buff *skb) >>> return skb_inner_network_header(skb) - skb->data; >>> } >>> >>> +/* We don't actually store the transport offset on backports because >>> + * we don't use it anywhere. Slightly rename this version to avoid >>> + * future users from picking it up accidentially. >>> + */ >> Can we add WARN_ON() to catch this case? > > I'm not sure what condition we would warn on this case. This function > actually does get called today, the issue is if there is a newer > caller expects that this returns a value other than 0.
I realized that you had already acked this and I'm not sure that there is anything more that we can do here, so I just pushed this to master. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
