There's some trailing whitespace and minor gramatical errors which I've fixed in the following patch. If you're willing to apply it, then go ahead and merge.
Acked-by: Ethan Jackson <et...@nicira.com> --- lib/perf-counter.c | 6 +++--- lib/perf-counter.h | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/perf-counter.c b/lib/perf-counter.c index 2600b6f..acafbef 100644 --- a/lib/perf-counter.c +++ b/lib/perf-counter.c @@ -108,7 +108,7 @@ static void perf_counter_to_ds(struct ds *ds, struct perf_counter *pfc) { double ratio; - + if (pfc->n_events) { ratio = (double)pfc->total_count / (double)pfc->n_events; } else { @@ -128,9 +128,9 @@ perf_counters_to_ds(struct ds *ds) err_str = NULL; if (fd__ == -1) { - err_str = "performance counter is not supported on this platfrom"; + err_str = "Performance counters are not supported on this platfrom."; } else if (!shash_count(&perf_counters)) { - err_str = "performance counter has never been hit"; + err_str = "Performance counters have never been hit."; } if (err_str) { diff --git a/lib/perf-counter.h b/lib/perf-counter.h index 6101d36..d61ace3 100644 --- a/lib/perf-counter.h +++ b/lib/perf-counter.h @@ -38,8 +38,8 @@ * - Hard coded to sample CPU cycle count in user space only. * - Only one counter is sampled. * - Useful macros are only provided for function profiling. - * - show and clear command applies to all counters, there is no way - * to select a sub-set of counter. + * - Show and clear command applies to all counters, there is no way + * to select a sub-set of counters. * * Those are not fundamental limits, but only limited by current * implementation. @@ -49,10 +49,10 @@ * * There are two macros provided: * - * Macro 'PERF_FUNCTON_COUNT_BEGIN' needs to be inserted towards the + * Macro 'PERF_FUNCTION_COUNT_BEGIN' needs to be inserted towards the * beginning of the function where local variables are declared. * - * Macro 'PERF_FUNCTON_COUNT_END' needs to appear in the same function, + * Macro 'PERF_FUNCTION_COUNT_END' needs to appear in the same function, * some where below 'PERF_FUNCTION_COUNT_BEGIN', usually towards of * a function. * @@ -71,7 +71,7 @@ * This will maintain the number of times 'my_func()' is called, total * number of instructions '<implementation>' executed during all those calls. * - * Currently there are two limitation: + * Currently there are two limitations: * 1). At most one pair can appear in the same variable scope. * 2). The Macros use function name as the counter name for display. * Thus, all functions in one annotation session are required to -- 1.9.1 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev