Sorin, I’ll put a breakpoint on OvsExtNetPnPEvent() like you suggested and see how this function is being used. Your patch is good, but I also feel we are only getting rid of a symptom rather than a problem. I feel you should also be removing the “switchActive == TRUE” check in the if() condition. I’ll update more later today.
thanks, -- Nithin > On Apr 15, 2015, at 10:30 AM, Sorin Vinturis > <[email protected]> wrote: > > I have removed an inappropriate assert from the FilterNetPnPEvent > routine, OvsExtNetPnPEvent. When NDIS calls the FilterNetPnPEvent > routine, the extension is in paused state and, obviously, the > switch is not active. The switch becomes active after FilterRestart > routine is called and the restart is successfully complete. > > v2: Splitted original patch into two patch series. > > v3: Added acked. > > Signed-off-by: Sorin Vinturis <[email protected]> > Acked-by: Eitan Eliahu <[email protected]> > --- > datapath-windows/ovsext/Switch.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/datapath-windows/ovsext/Switch.c > b/datapath-windows/ovsext/Switch.c > index 2b9a713..cfbb5a0 100644 > --- a/datapath-windows/ovsext/Switch.c > +++ b/datapath-windows/ovsext/Switch.c > @@ -523,7 +523,6 @@ OvsExtNetPnPEvent(NDIS_HANDLE filterModuleContext, > switchContext->isActivateFailed = TRUE; > } else { > ASSERT(switchContext->isActivated == FALSE); > - ASSERT(switchActive == TRUE); > if (switchContext->isActivated == FALSE && switchActive == TRUE) { > status = OvsActivateSwitch(switchContext); > OVS_LOG_TRACE("OvsExtNetPnPEvent: activated switch: %p " > -- > 1.9.0.msysgit.0 > _______________________________________________ > dev mailing list > [email protected] > https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=tQ_OMBHUhKipLUTLtQiZKCabsdkBWFtB2SeaN52EA7o&s=8whqj2DeIOWfPModyaP_IT4bpUrSFwvXCJsa-Ie_3HE&e= > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
