On Mon, Apr 20, 2015 at 1:17 AM, Thomas Graf <[email protected]> wrote:
> On 04/19/15 at 10:15pm, Alex Wang wrote: > > With the latest change of separating vports into their own modules, > > it is necessary to export all public functions in linux/compat/linux/. > > This will prevent the linker error when vport modules use those > > functions in the future. e.g., the to be merged vport-stt module will > > use the flex_array_* functions which are not currently exported. > > > > Signed-off-by: Alex Wang <[email protected]> > > I wanted to avoid exporting all symbols if possible. We basically > need to add rpl defines for most of them if we want to do so. > Hi Thomas, Could you explain more? My understanding is that even we rpl define them we still need to export the symbol if the function is used in a vport-* module. Unless we all inline them. Also, for the linker error, when I test with the stt module (have not merged yet), I got this error on older kernel (2.6): vport_stt: Unknown symbol flex_array_prealloc vport_stt: Unknown symbol flex_array_alloc vport_stt: Unknown symbol flex_array_free vport_stt: Unknown symbol flex_array_get Thanks, Alex Wang, _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
