> On Apr 21, 2015, at 7:44 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Tue, Apr 21, 2015 at 03:20:33PM -0700, Justin Pettit wrote: >> >> I don't see how this works, since lexer_get() is not initially called. > > I'm getting the impression you're less comfortable than me with > partially implementing a vague specification. I sent a fix: > http://openvswitch.org/pipermail/dev/2015-April/054441.html
Well, I guess I do have a preference that they either work as specified or we note somewhere things that we know won't work. I'd be just as happy if we put in the TODO list things that we know we need to come back to. I just find review time a good opportunity to catch things, because it's really the only time we're scouring the code. Later on, a lot of these issues may show up as bugs or slow down development as someone has to rediscover that there's missing features that they were expecting to work. Speaking of, this patch series ticked off at least a couple of items from the TODO list, which can now be removed. It's great to see it getting whittled down. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
