> On May 1, 2015, at 4:17 PM, Ben Pfaff <[email protected]> wrote:
>
>
> +/* Adds a flow with the specified 'match' and 'actions' to the OpenFlow table
> + * numbered 'table_id' with the given 'priority'.
> + *
> + * This just assembles the desired flow table in memory. Nothing is actually
> + * sent to the switch until a later call to ofctrl_run(). */
> +void
> +ofctrl_add_flow(uint8_t table_id, uint16_t priority,
> + const struct match *match, const struct ofpbuf *ofpacts)
The function and comment refer to the supplied actions differently ("ofpacts"
vs "actions"). I think "actions" may be a better name, since it's going into
an array of type "ofpact", which is a little confusing.
Do you think it's worth saying that ownership of the arguments is maintained by
the caller?
Acked-by: Justin Pettit <[email protected]>
--Justin
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
