Re: [ovs-dev] [PATCH 1/5] datapath-windows: Added new function for native forwarded traffic

[Nithin Raju]

> On Apr 23, 2015, at 2:05 PM, Sorin Vinturis 
> <svintu...@cloudbasesolutions.com> wrote:
> 
> Signed-off-by: Sorin Vinturis <svintu...@cloudbasesolutions.com>

hi Sorin,
Thanks for these patches. They are super important. This one looks good, but 
for a couple of minor comments. I’ll review the rest of them too.

Acked-by: Nithin Raju <nit...@vmware.com>

> @@ -255,10 +235,30 @@ OvsStartNBLIngress(POVS_SWITCH_CONTEXT switchContext,
>         OvsFlowKey key;
>         UINT64 hash;
>         PNET_BUFFER curNb;
> +        BOOLEAN isRecv = FALSE;

minor: is it necessary to initialize ‘isRecv’? Can be avoided.

> +#if (NDIS_SUPPORT_NDIS640)
> +        if (fwdDetail->NativeForwardingRequired) {
> +            /* Add current NBL to the those that require native forwarding. 
> */

minor: “to the those” => “to those”

thanks,
-- Nithin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev