OpenFlow 1.3 says:
If a switch cannot add the incoming group entry due to restrictions
(hardware or otherwise) limiting the number of group buckets, it must
refuse to add the group entry and must send an ofp_error_msg with
OFPET_GROUP_MOD_FAILED type and OFPGMFC_OUT_OF_BUCKETS code.
This indicates that OFPGMFC_OUT_OF_BUCKETS is appropriate for an indirect
group with the wrong number of buckets, but OVS was using a different
error. This fixes the problem.
ONF-JIRA: EXT-546
Reported-by: Mrinmoy Das <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
---
AUTHORS | 1 +
lib/ofp-util.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
index 255cc42..1a371b6 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -302,6 +302,7 @@ Mike Bursell [email protected]
Mike Kruze [email protected]
Min Chen [email protected]
Mikael Doverhag [email protected]
+Mrinmoy Das [email protected]
Nagi Reddy Jonnala [email protected]
Niels van Adrichem [email protected]
Niklas Andersson [email protected]
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 60cc674..6366919 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -8375,7 +8375,7 @@ ofputil_decode_group_mod(const struct ofp_header *oh,
switch (gm->type) {
case OFPGT11_INDIRECT:
if (!list_is_singleton(&gm->buckets)) {
- return OFPERR_OFPGMFC_INVALID_GROUP;
+ return OFPERR_OFPGMFC_OUT_OF_BUCKETS;
}
break;
case OFPGT11_ALL:
--
2.1.3
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
