On Thu, May 21, 2015 at 4:39 PM, Jarno Rajahalme <jrajaha...@nicira.com> wrote: > OVS kernel module support for masked set actions in already upstream > in Linux. This patch adds the same for the OVS tree kernel module. > > The existing set action sets many fields at once. When only a subset > of the IP header fields, for example, should be modified, all the IP > fields need to be exact matched so that the other field values can be > copied to the set action. A masked set action allows modification of > an arbitrary subset of the supported header bits without requiring the > rest to be matched. > > Masked set action is now supported for all writeable key types, except > for the tunnel key. The set tunnel action is an exception as any > input tunnel info is cleared before action processing starts, so there > is no tunnel info to mask. > > The kernel module converts all (non-tunnel) set actions to masked set > actions. This makes action processing more uniform, and results in > less branching and duplicating the action processing code. When > returning actions to userspace, the conversion is inverted. We use a > kernel internal action code to be able to tell the userspace provided > and converted masked set actions apart. > > Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
Can you also add the upstream commit ID to the change log? (it's 83d2b9ba1abca241df44a502b6da950a25856b5b). Otherwise, this looks basically the same as the upstream patch and I nothing that should require special backporting comes to mind, so looks good to me. Acked-by: Jesse Gross <je...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
