On Fri, May 22, 2015 at 2:38 PM, Joe Stringer <[email protected]> wrote:
> On 22 May 2015 at 14:34, Andy Zhou <[email protected]> wrote:
>> On Fri, May 22, 2015 at 2:28 PM, Joe Stringer <[email protected]> wrote:
>>> The match is in hex, this makes it more consistent.
>>>
>>> Signed-off-by: Joe Stringer <[email protected]>
>>> ---
>>> lib/odp-util.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/odp-util.c b/lib/odp-util.c
>>> index 962b84b..6e2a39d 100644
>>> --- a/lib/odp-util.c
>>> +++ b/lib/odp-util.c
>>> @@ -495,7 +495,7 @@ format_mpls(struct ds *ds, const struct ovs_key_mpls
>>> *mpls_key,
>>> static void
>>> format_odp_recirc_action(struct ds *ds, uint32_t recirc_id)
>>> {
>>> - ds_put_format(ds, "recirc(%"PRIu32")", recirc_id);
>>> + ds_put_format(ds, "recirc(%"PRIx32")", recirc_id);
>>> }
>>>
>> It may be better to explicitly display numbers in hex. Adding leading
>> '0x' will probably make it less confusing.
>
> Even better. (I thought it was already given in PRIx32 but apparently not.)
>
> Acked-by: Joe Stringer <[email protected]>
Thanks, Pushed both patches with both of us on the Sign-off line.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
