hi Sorin, This patch looks much better. Like I mentioned the review to the previous revision, a duplicate vport delete request for the same VXLAN port can mess things up, including accessing a freed up ‘vport’ structure. But, that is a corner case, and we can address it later.
I just found a new issue in OvsTunnelVportPendingUninit() where you are not taking the vport lock (switchContext->dispatchLock). Looks good otherwise. > +static VOID > +OvsTunnelVportPendingUninit(PVOID context, > + NTSTATUS status, > + UINT32 *replyLen) You are not taking the switchContext->dispatchLock while deleting from the hash tables. I should be able to ACK the next revision. thanks, -- Nithin _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
