On Thu, Apr 09, 2015 at 06:40:12PM -0700, Andy Zhou wrote: > To make ovsdb_monitor an opaque to ovsdb_jsonrpc server object. > > Signed-off-by: Andy Zhou <[email protected]> > Acked-by: Ben Pfaff <[email protected]>
I think that the change from |= to = in this commit is going to break some corner cases where different columns within a table have different monitoring requirements. I'd change ovsdb_monitor_set_select() to use |=, and perhaps rename it to reflect that change |(ovsdb_monitor_add_select()?). Acked-by: Ben Pfaff <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
