Is actually adding a new feature rather than fix a bug?
Actually v2 fixes a bug that was in the original patch (v1) that was sent
out.
If so, you may also want to update the man pages with the new usage
and add unit tests for it.
I'll add the manpage extension and resend v3, but I'm not sure about the
unit tests that needs to be added. Can you point me to what needs to be
done to the framework?
If this patch also fixes bugs, then the bug fix should be in a separate patch.
No, it does not fix any bug. It just fixes a defect in my original
implementation.
What would be default argument for the new 'table' argument if it is
not specified?
It dumps the whole db as indicated in the usage:
dump [SERVER] [DATABASE] [TABLE]
dump contents of table(s) in DATABASE on SERVER to stdout
"TABLE" is optional.
Just to make sure we are not feature creeping, Can this be achieved via
shell scripts running on top of 'ovsdb-client dump db'?
Currently 'ovsdb-client dump' dumps the whole db, which can be lot of
output. Cannot think of an easier way than writing a python script that goes
over the entire output, then parses and prints the particular table in
question. Bash scripting may not be so easy to write as tables can have
varied number of rows. Its probably more practical and user friendly to have
something in ovsdb-client itself that dumps a table rather than have users
distribute/write custom scripts, especially if db is large in size..
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
