On Fri, Jun 26, 2015 at 10:20:02PM +0000, Alin Serdean wrote: > Acked-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> > > -----Mesaj original----- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Friday, June 26, 2015 9:51 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 2/2 v3][branch 2.4] datapath-windows: Rename > 'vport->isPresentOnHv' to 'isAbsentOnHv' > > Looking at the code, the flag 'vport->isPresentOnHv' is actually indicating > if the vport is present on the Hyper-V switch or not, but the logic seems to > be inverse. 'isPresentOnHv == TRUE' indicates that the vport is not present > on the Hyper-V switch. Eg. VXLAN port, would have isPresentOnHv == TRUE. > > In this patch, we rename the variable to reflect its meaning. > > vport->isAbsentOnHv is TRUE iff: > - vport is bridge internal port > - vport is tunnel port > - vport was added from Hyper-V and also from OVS, but got deleted from Hyper-V > > Signed-off-by: Nithin Raju <nit...@vmware.com> > --- > v2: created a series > v3: addressed the issues Alin found during validation
Thanks Nithin and Alin! I applied both of these to master and branch-2.4. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
