Hi Sorin, Please consider to have the dump state as part of the usermode instance (regardless if dump initiated or not). This would save the whole housekeeping around this insignificant dynamic memory allocation. Thanks, Eitan
-----Original Message----- From: dev [mailto:[email protected]] On Behalf Of Alin Serdean Sent: Thursday, July 02, 2015 12:24 AM To: Sorin Vinturis; [email protected] Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved memory leak in OVS datapath Acked-by: Alin Gabriel Serdean <[email protected]> -----Mesaj original----- De la: dev [mailto:[email protected]] În numele Sorin Vinturis Trimis: Thursday, July 2, 2015 9:53 AM Către: [email protected] Subiect: [ovs-dev] [PATCH] datapath-windows: Solved memory leak in OVS datapath When closing opened instances, make sure the user dump state is cleared. Signed-off-by: Sorin Vinturis <[email protected]> Reported-by: Sorin Vinturis <[email protected]> Reported-at: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs-2Dissues_issues_90&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=y9vDcTc0RXTftcLjlqfZ62P-E9kaIrToeowiiE1Xsx4&s=2ysWHleKrgA8nBthYFZPPmIcC0WCECIbOSO4Am6j_M8&e= --- This patch should be applied both on master and branch 2.4. --- datapath-windows/ovsext/Datapath.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c index d8024c8..4af909c 100644 --- a/datapath-windows/ovsext/Datapath.c +++ b/datapath-windows/ovsext/Datapath.c @@ -588,6 +588,7 @@ OvsRemoveOpenInstance(PFILE_OBJECT fileObject) OvsReleaseCtrlLock(); ASSERT(instance->eventQueue == NULL); ASSERT (instance->packetQueue == NULL); + FreeUserDumpState(instance); OvsFreeMemoryWithTag(instance, OVS_DATAPATH_POOL_TAG); } -- 1.9.0.msysgit.0 _______________________________________________ dev mailing list [email protected] https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=y9vDcTc0RXTftcLjlqfZ62P-E9kaIrToeowiiE1Xsx4&s=ZlPfSZTKWL7e49wkW7YE6wpMtK_43vjgKepE_68sKqo&e= _______________________________________________ dev mailing list [email protected] https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=y9vDcTc0RXTftcLjlqfZ62P-E9kaIrToeowiiE1Xsx4&s=ZlPfSZTKWL7e49wkW7YE6wpMtK_43vjgKepE_68sKqo&e= _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
