On Mon, Jul 06, 2015 at 05:46:36PM -0700, Justin Pettit wrote: > > > > On Jul 6, 2015, at 2:42 PM, Ben Pfaff <[email protected]> wrote: > > > > The recommended Google Python style is multi_word_names, not > > multiWordNames. > > > > There are lots of other places where the style could be improved. > > I started here because I was working in this code anyway and because > > this code is only used at build time and not installed, so that it > > can't break any third-party code. > > > > Signed-off-by: Ben Pfaff <[email protected]> > > For the name changes: > > Acked-by: Justin Pettit <[email protected]>
Thanks, applied. > > + elif node.tagName == 'diagram': > > + s += diagram_to_nroff(node.childNodes, para) > > Did you mean to include these "diagram_to_nroff" changes in this > commit? It doesn't seem related to the description, and it introduces > two non-trivial functions: diagram_to_nroff() and > diagram_header_to_nroff(). I didn't bother reviewing them, since I > imagine they were included in error. Let me know if I'm mistaken, > though, and I'll review them. Apparently I inadvertently squashed that in. Oops. Removed. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
