Hi Ben, The main problem in the whole implementation which I am facing currently is in encoding and decoding of table-mod config value. For table-config, as per the specification we can send only three values - OFPTC14_EVICTION, OFPTC14_VACANCY_EVENTS and 0.
As per the current implementation: Eviction On -- "ovs-ofctl -O openflow14 mod-table <br> <table-id> evict"-- OFPTC14_EVICTION is sent as config value and Eviction Off -- "ovs-ofctl -O openflow14 mod-table <br> <table-id> noevict"-- 0 is sent as config value. Similarly for Vacancy events implementation: Vacancy is turned On -- "ovs-ofctl -O openflow14 mod-table <br> <table-id> vacancy-<low..high>"- OFPTC14_VACANCY_EVENTS are send as as table config value Vacancy Off -- "ovs-ofctl -O openflow14 mod-table <br> <table-id> novacancy"-- 0 should be send as table-config. As for "noevict" and "novacancy", 0 is send as config value in table-mod so the problem arises while decoding, it is not clear whether to decode "0" for "noevict" or for "novacancy", that is when 0 is received as table config parameter and both eviction and vacancy are set for that table, we cannot decode and find out whether to turn-off eviction or to turn-off vacancy events for that table. So what I think instead of doing "ovs-ofctl -O openflow14 mod-table <br> <table-id> noevict" and "ovs-ofctl -O openflow14 mod-table <br> <table-id> novacancy", a single command "ovs-ofctl -O openflow14 mod-table <br> <table-id> clear" should be made for which 0 is send as config parameter and it will clear both vacancy and Eviction table-config property. Thanks and Regards, Saloni Jain Tata Consultancy Services Mailto: saloni.j...@tcs.com Website: http://www.tcs.com ____________________________________________ Experience certainty. IT Services Business Solutions Consulting ____________________________________________ -----Ben Pfaff <b...@nicira.com> wrote: ----- To: Saloni Jain <saloni.j...@tcs.com> From: Ben Pfaff <b...@nicira.com> Date: 07/16/2015 11:13PM Cc: dev@openvswitch.org, Deepankar Gupta <deepankar.gu...@tcs.com>, Partha Datta <partha.da...@tcs.com> Subject: Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events On Thu, Jul 16, 2015 at 12:26:20PM +0530, Saloni Jain wrote: > So what I think that instead of "ovs-ofctl table-mod" to use an > OFPMP_TABLE_DESC request to obtain the current configuration, then > modify it according to the user's request, "ovs-vswitchd" should query > and store the current table-configuration and modify it with user's > request, as in this case both "primary controller" and "service > controller" will be taken into consideration. Please describe the details of how you intend to do that. I can't see how it would work. =====-----=====-----===== Notice: The information contained in this e-mail message and/or attachments to it may contain confidential or privileged information. If you are not the intended recipient, any dissemination, use, review, distribution, printing or copying of the information contained in this e-mail message and/or attachments to it are strictly prohibited. If you have received this communication in error, please notify us by reply e-mail or telephone and immediately and permanently delete the message and any attachments. Thank you _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
