On Tue, Jul 28, 2015 at 03:22:46PM -0700, Ben Pfaff wrote:
> This is implied by the list of ports that are valid for output in the
> various versions of the OpenFlow specification.
> 
> Found by OFTest.

Looks good to me.
I wonder how one could set the output port to none.

Acked-by: Flavio Leitner <[email protected]>


> Signed-off-by: Ben Pfaff <[email protected]>
> ---
>  lib/ofp-actions.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
> index eef3389..14a2802 100644
> --- a/lib/ofp-actions.c
> +++ b/lib/ofp-actions.c
> @@ -5396,10 +5396,12 @@ ofpact_check_output_port(ofp_port_t port, ofp_port_t 
> max_ports)
>      case OFPP_FLOOD:
>      case OFPP_ALL:
>      case OFPP_CONTROLLER:
> -    case OFPP_NONE:
>      case OFPP_LOCAL:
>          return 0;
>  
> +    case OFPP_NONE:
> +        return OFPERR_OFPBAC_BAD_OUT_PORT;
> +
>      default:
>          if (ofp_to_u16(port) < ofp_to_u16(max_ports)) {
>              return 0;
> -- 
> 2.1.3
> 
> _______________________________________________
> dev mailing list
> [email protected]
> http://openvswitch.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to