Sorry for taking so long to get to this. The one question I have is: Is OVS the right layer to be fixing this? Isn't this really an issue of DPDK reporting a number of available queues that for practical purposes is wrong? I.E. Shouldn't this be fixed by the DPDK driver of this system? This patch feels like a hack to me . . .
Ethan On Tue, Jul 28, 2015 at 2:36 AM, Stokes, Ian <[email protected]> wrote: > Hi all, > > Just wondering what the status of this patch is? Is there any feedback > or queries we can answer to help? > > Thanks > Ian > >> -----Original Message----- >> From: dev [mailto:[email protected]] On Behalf Of Traynor, >> Kevin >> Sent: Thursday, July 23, 2015 11:28 AM >> To: Daniele Di Proietto; [email protected] >> Subject: Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup >> until we don't get any failure. >> >> >> > -----Original Message----- >> > From: dev [mailto:[email protected]] On Behalf Of Daniele Di >> > Proietto >> > Sent: Thursday, July 16, 2015 7:48 PM >> > To: [email protected] >> > Subject: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup >> until we >> > don't get any failure. >> > >> > It has been observed that some DPDK device (e.g intel xl710) report an >> > high number of queues but make some of them available only for special >> > functions (SRIOV). Therefore the queues will be counted in >> > rte_eth_dev_info_get(), but rte_eth_tx_queue_setup() will fail. >> > >> > This commit works around the issue by retrying the device >> initialization >> > with a smaller number of queues, if a queue fails to setup. >> > >> > Reported-by: Ian Stokes <[email protected]> >> > Signed-off-by: Daniele Di Proietto <[email protected]> >> > --- >> > lib/netdev-dpdk.c | 100 +++++++++++++++++++++++++++++++++++++++------ >> ------- >> > -- >> > 1 file changed, 73 insertions(+), 27 deletions(-) >> >> >> Acked-by: Kevin Traynor <[email protected]> >> _______________________________________________ >> dev mailing list >> [email protected] >> http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ > dev mailing list > [email protected] > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
