On 30 July 2015 at 10:08, Jesse Gross <[email protected]> wrote: > On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer <[email protected]> wrote: >> Signed-off-by: Joe Stringer <[email protected]> >> --- >> datapath/datapath.c | 25 +++++++++++++------------ >> datapath/datapath.h | 2 +- >> 2 files changed, 14 insertions(+), 13 deletions(-) > > If I remember correctly the reason why these weren't marked const is > because older kernels had functions that took these parameters as > non-const and it provoked warnings. However, it seems to me that we > have mostly redefined the places where these are passed, so perhaps > it's not an issue anymore. Can you double check to see if that's the > case? If so, this looks good to me. > > Acked-by: Jesse Gross <[email protected]>
I took a quick scan through my travis build of this, and I don't see any warnings, eg v2.6.32.65: https://travis-ci.org/joestringer/openvswitch/jobs/73239310 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
