Hello Ben, Thanks for your comments.
In ipfix and sflow, the sampling rate can be set as 1, which means 100%. And in order to make 100% packets sampled, I work out a patch in datapath, which is for review on net-next. And the same change seems need to be added into lib/odp-execute.c too. Do you mean that it is not necessary here? Bests, Wenyu > On Aug 4, 2015, at 12:37 AM, Ben Pfaff <b...@nicira.com> wrote: > > On Sun, Aug 02, 2015 at 11:54:09PM -0700, Wenyu Zhang wrote: >> When sampling rate is 1, the sampling probability is UINT32_MAX. The packet >> should be sampled even the prandom32() generate the number of UINT32_MAX. >> And none packet need be sampled when the probability is 0. > > If we have code that generates either 0% or 100% probabilities, we > should probably adjust it so that it doesn't do that. Neither of these > probabilities is useful. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
