On Tue, Aug 25, 2015 at 04:41:25PM +0530, [email protected] wrote: > From: Niti Rohilla <[email protected]> > > This patch adds support for Openflow1.4 Group & meter change notification > messages. In a multi controller environment, when a controller modifies the > state of group and meter table, the request that successfully modifies this > state is forwarded to other controllers. Other controllers are informed with > the OFPT_REQUESTFORWARD message. Request forwarding is enabled on a per > controller channel basis using the Set Asynchronous Configuration Message. > > Signed-off-by: Niti Rohilla <[email protected]>
ofputil_re_encode_requestforward() has memory leaks because it doesn't free data in the decoded group_mod or meter_mod after finishing with them. I'd like to see a test added for the case where the request has to be re-encoded; I don't think that ofputil_re_encode_requestforward() is getting exercised at all in the testsuite. I guess an alternative, if you prefer it, is to always re-encode the request, even if it is the same version. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
