On Thu, Sep 10, 2015 at 11:50:37AM +0530, niti Rohilla wrote:
> Thanks for the review. Yes, I find this approach better where data is
> decoded only once.
>
> I have a doubt regarding the following structure:
>
> struct ofputil_requestforward {
> ovs_be32 xid;
> enum ofp14_requestforward_reason reason;
> union {
> /* reason == OFPRFR_METER_MOD. */
> struct ofputil_meter_mod *meter_mod;
>
> /* reason == OFPRFR_GROUP_MOD. */
> struct {
> struct ofputil_group_mod *group_mod;
> struct ofpbuf bands;
> };
> };
> };
>
> Here, 'bands' are included as a part of group_mod, but as per the code and
> specification, bands are part of meter_mod. Please help me understand why
> 'bands' have been included with group_mod. As per my understanding, the
> structure should be in this manner:
>
> struct ofputil_requestforward {
> ovs_be32 xid;
> enum ofp14_requestforward_reason reason;
> union {
> /* reason == OFPRFR_METER_MOD. */
> struct {
> struct ofputil_meter_mod *meter_mod;
> struct ofpbuf bands;
> };
>
> /* reason == OFPRFR_GROUP_MOD. */
> struct ofputil_group_mod *group_mod;
> };
> };
Thanks for the report. I sent out a fix for review:
http://openvswitch.org/pipermail/dev/2015-September/059850.html
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
