Thanks for clarifying that. Acked-by: Sairam Venugopal <vsai...@vmware.com>
On 9/14/15, 1:53 PM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >The idea is there are two type of errors: >- those returned by the system: i.e. the result code that you pointed >below which gets interpreted by >(https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswit >ch_ovs_blob_master_lib_netlink-2Dsocket.c-23L567&d=BQIFAw&c=Sqcl0Ez6M0X8ae >M67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dcruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JE >Q&m=Z7ZoVyMm_NZ6MNNEvqTPDS_mM1DBg4b_GNVSNwTRzRo&s=0EgMDxwB9P0Qjww2as2M01UT >6qUKYvKo4aCRNl_Rse0&e= ). Which means that was a system error. >- netlink errors which will determine the userspace to make appropriate >decisions based on that error. > >The rc is set to success so that we tell the userspace that there was no >system error but there was a netlink error. > >Alin. > >> done: >>+ if (nlError != NL_ERROR_SUCCESS) { >>+ POVS_MESSAGE_ERROR msgError = (POVS_MESSAGE_ERROR) >>+ usrParamsCtx->outputBuffer; >>+ NlBuildErrorMsg(msgIn, msgError, nlError); >>+ *replyLen = msgError->nlMsg.nlmsgLen; > >Sai: Should rc be set to STATUS_SUCCESS? Isn¹t this a failure condition >that will affect the calling function? > >>+ rc = STATUS_SUCCESS; >>+ } >>+ >> return rc; >> } > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
