On Sat, Oct 24, 2015 at 2:02 PM, Ben Pfaff <b...@nicira.com> wrote: > On Fri, Oct 09, 2015 at 05:13:23PM -0700, Andy Zhou wrote: >> Add option to ovs-ctl script to specify whether to start the daemons as >> root user or ovs user. The default is 'run-as-root', which preserves >> the script's current behavior. >> >> Signed-off-by: Andy Zhou <az...@nicira.com> > > I think that the implementation is fine but I'm nervous about the option > name. I prefer positive names over negative ones because they are > generally more meaningful to users. > > Here, for example, one option would be to support --run-as=user[:group]. > Then one could invoke it as --run-as=root or --run-as=ovs. That also > gives more control to the caller since it can now specify specifically > what user it wants. > > Whether the option name is changed or not, this commit should update the > ovs-ctl manpage. Thanks for the review and suggestion.
I will implement --run-as and fix ova-ctl manpage in the next rev. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
