On Thu, Dec 10, 2015 at 05:58:12PM -0800, William Tu wrote: > Fix some of the "definitely loss" cases reported by Valgrind. > > Signed-off-by: William Tu <[email protected]> > Signed-off-by: Daniele Di Proietto <[email protected]> > Co-authored-by: Daniele Di Proietto <[email protected]>
I'd appreciate it if you'd separate the real memory leaks (the ones that can occur in daemons or in the library) from the pseudo-leaks that don't matter (the ones in test programs or the ones that are followed by a call to exit() or similar). It's OK to fix both of them but they should be in separate commits for reader clarity and because it makes more sense to backport the real fixes. There's quite a bit of wrong indentation here. I think that you must be, at least in some places, indenting with some narrow tab width instead of with spaces. There are now a few patch rejects since master has drifted a bit (sorry to take so long to review this). I did skim over the remaining changes and I didn't spot any problems. I'd appreciate it if you'd rebase and repost this. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
